Choose best launch position based on y-coordinate and enemy distance

1 files changed, 15 insertions, 14 deletions

diff --git a/TemplePushing.c4s/Script.c b/TemplePushing.c4s/Script.c
index 197757c..f37c183 100644
--- a/TemplePushing.c4s/Script.c
+++ b/TemplePushing.c4s/Script.c
@@ -560,28 +560,29 @@ func LaunchClonk(int player, object clonk, bool relaunch)
 
 	// Move clonk to random position
 
-	var NumCheckPos = 25;
-	var positions = CreateArray(NumCheckPos);
+	var maxDistance = Distance(0, 0, LandscapeWidth(), LandscapeHeight());
+	var bestPosition = [LandscapeWidth() / 2, LandscapeHeight() / 2], bestQuality = 0;
 
-	for (var i = 0; i < NumCheckPos; ++i)
+	// Generate 25 random positions and choose best
+	for (var i = 0; i < 25; ++i)
 	{
+		// Place wipf, save its position and remove it
 		var wipf = PlaceAnimal(WIPF);
-		positions[i] = IIf(wipf, [wipf->GetX(), wipf->GetY()], [LandscapeWidth() / 2, LandscapeHeight() / 2]);
+		if (!wipf) continue;
+		var pos = IIf(wipf, [wipf->GetX(), wipf->GetY()], bestPosition);
 		if (wipf) wipf->RemoveObject();
-	}
 
-	// Prevent spawning too close to an enemy
+		// Get distance to closest enemy
+		var closestEnemy = FindObject2(Find_OCF(OCF_CrewMember | OCF_Alive), Find_Hostile(player), Sort_Distance(pos[0], pos[1]));
+		var enemyDistance;
+		if (closestEnemy) enemyDistance = Distance(pos[0], pos[1], closestEnemy->GetX(), closestEnemy->GetY());
 
-	var bestPosition = positions[0], bestDistance = 0;
-	for (var pos in positions)
-	{
-		var closestHostileClonk = FindObject2(Find_OCF(OCF_CrewMember | OCF_Alive), Find_Hostile(player), Sort_Distance(pos[0], pos[1]));
-		if (!closestHostileClonk) break;
-		var distance = Distance(pos[0], pos[1], closestHostileClonk->GetX(), closestHostileClonk->GetY());
-		if (distance > bestDistance)
+		// Calculate quality of position from its y-value and its distance to the closest enemy and use position if it is the best
+		var quality = (LandscapeHeight() - pos[1]) * 1000 / LandscapeHeight() + enemyDistance * 1000 / maxDistance;
+		if (quality > bestQuality)
 		{
 			bestPosition = pos;
-			bestDistance = distance;
+			bestQuality = quality;
 		}
 	}